drm: Don't set the plane->fb to NULL on successfull set_plane
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 15 Feb 2013 20:21:37 +0000 (21:21 +0100)
committerDave Airlie <airlied@redhat.com>
Tue, 19 Feb 2013 22:47:54 +0000 (08:47 +1000)
commit35f8badc1cf652381fa3f82c1fbea39f4dbe87fd
treec2a9a4df9864daf8647bcab7fa5b469da2034440
parent196e077dc165a307efbd9e7569f81bbdbcf18f65
drm: Don't set the plane->fb to NULL on successfull set_plane

We need to clear the local variable to get the refcounting right
(since the reference drm_mode_setplane holds is transferred to the
plane->fb pointer). But should be done _after_ we update the pointer.

Breakage introduced in

commit 6c2a75325c800de286166c693e0cd33c3a1c5ec8
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Tue Dec 11 00:59:24 2012 +0100

    drm: refcounting for sprite framebuffers

Reported-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Rob Clark <rob@ti.com>
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Thierry Reding <thierry.reding@avionic-design.de>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/drm_crtc.c