tg3: driver sleeps indefinitely when EEH errors exceed eeh_max_freezes
authorDavid Christensen <drc@linux.vnet.ibm.com>
Wed, 17 Jun 2020 18:51:17 +0000 (11:51 -0700)
committerSasha Levin <sashal@kernel.org>
Tue, 30 Jun 2020 19:36:46 +0000 (15:36 -0400)
commit35db638692db1e696855b78897e363ef150306d0
treef3136d417d6e86a000d29fa133acbd0c3e260893
parentfe3a5d8fc372285a292af315ea1ea75a7cafc8ce
tg3: driver sleeps indefinitely when EEH errors exceed eeh_max_freezes

[ Upstream commit 3a2656a211caf35e56afc9425e6e518fa52f7fbc ]

The driver function tg3_io_error_detected() calls napi_disable twice,
without an intervening napi_enable, when the number of EEH errors exceeds
eeh_max_freezes, resulting in an indefinite sleep while holding rtnl_lock.

Add check for pcierr_recovery which skips code already executed for the
"Frozen" state.

Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/broadcom/tg3.c