Compute A-B when A or B is weak.
authorRafael Espindola <rafael.espindola@gmail.com>
Fri, 17 Apr 2015 21:15:17 +0000 (21:15 +0000)
committerRafael Espindola <rafael.espindola@gmail.com>
Fri, 17 Apr 2015 21:15:17 +0000 (21:15 +0000)
commit35d6189f0fc2bbb103846ffaac4b3e0043607885
tree24b20082223c32a65f69a5181b5e7f7efdf61b9b
parent84b801f6b46520611d4428e6facd7c09489ae516
Compute A-B when A or B is weak.

Similar to r235222, but for the weak symbol case.

In an "ideal" assembler/object format an expression would always refer to the
final value and A-B would only be computed from a section in the same
comdat as A and B with A and B strong.

Unfortunately that is not the case with debug info on ELF, so we need an
heuristic.  Since we need an heuristic, we may as well use the same one as
gas:

* call weak_sym : produces a relocation, even if in the same section.
* A - weak_sym and weak_sym -A: don't produce a relocation if we can
  compute it.

This fixes pr23272 and changes the fix of pr22815 to match what gas does.

llvm-svn: 235227
llvm/include/llvm/MC/MCMachObjectWriter.h
llvm/include/llvm/MC/MCObjectWriter.h
llvm/lib/MC/ELFObjectWriter.cpp
llvm/lib/MC/MCAssembler.cpp
llvm/lib/MC/MCObjectWriter.cpp
llvm/lib/MC/MachObjectWriter.cpp
llvm/lib/MC/WinCOFFObjectWriter.cpp
llvm/test/MC/ELF/weak-diff.s
llvm/test/MC/ELF/weak-diff2.s [deleted file]