USB: serial: keyspan: fix use-after-free in probe error path
authorJohan Hovold <johan@kernel.org>
Sun, 8 May 2016 18:07:58 +0000 (20:07 +0200)
committerJohan Hovold <johan@kernel.org>
Tue, 10 May 2016 07:39:40 +0000 (09:39 +0200)
commit35be1a71d70775e7bd7e45fa6d2897342ff4c9d2
treef1b548cacde7b31f3ba2cd292ca2cf892cb66322
parentc8d62957d450cc1a22ce3242908709fe367ddc8e
USB: serial: keyspan: fix use-after-free in probe error path

The interface instat and indat URBs were submitted in attach, but never
unlinked in release before deallocating the corresponding transfer
buffers.

In the case of a late probe error (e.g. due to failed minor allocation),
disconnect would not have been called before release, causing the
buffers to be freed while the URBs are still in use. We'd also end up
with active URBs for an unbound interface.

Fixes: f9c99bb8b3a1 ("USB: usb-serial: replace shutdown with disconnect,
release")
Cc: stable <stable@vger.kernel.org> # v2.6.31
Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/keyspan.c