net_sched: remove a bogus warning in hfsc
authorCong Wang <xiyou.wangcong@gmail.com>
Fri, 22 Jun 2018 21:33:16 +0000 (14:33 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 23 Jun 2018 01:58:46 +0000 (10:58 +0900)
commit35b42da69e35536da603a50e40aa6c41b2f7b0f8
tree45c3abeae1f65f4552c3ce5fdd2c01a032e15670
parent2ca4eb85744b1cd93076418ac8430ba527cc35bb
net_sched: remove a bogus warning in hfsc

In update_vf():

  cftree_remove(cl);
  update_cfmin(cl->cl_parent);

the cl_cfmin of cl->cl_parent is intentionally updated to 0
when that parent only has one child. And if this parent is
root qdisc, we could end up, in hfsc_schedule_watchdog(),
that we can't decide the next schedule time for qdisc watchdog.
But it seems safe that we can just skip it, as this watchdog is
not always scheduled anyway.

Thanks to Marco for testing all the cases, nothing is broken.

Reported-by: Marco Berizzi <pupilla@libero.it>
Tested-by: Marco Berizzi <pupilla@libero.it>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_hfsc.c