netfilter: revert introduction of egress hook
authorDaniel Borkmann <daniel@iogearbox.net>
Wed, 18 Mar 2020 09:33:22 +0000 (10:33 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 18 Mar 2020 23:35:48 +0000 (16:35 -0700)
commit357b6cc5834eabc1be7c28a9faae7da061df097d
tree115ada0d38fbd89d8be6ffc03c27c22e3bcdb4b5
parentce7964bdc414b1ab6a7d3678ba064548c0bee973
netfilter: revert introduction of egress hook

This reverts the following commits:

  8537f78647c0 ("netfilter: Introduce egress hook")
  5418d3881e1f ("netfilter: Generalize ingress hook")
  b030f194aed2 ("netfilter: Rename ingress hook include file")

>From the discussion in [0], the author's main motivation to add a hook
in fast path is for an out of tree kernel module, which is a red flag
to begin with. Other mentioned potential use cases like NAT{64,46}
is on future extensions w/o concrete code in the tree yet. Revert as
suggested [1] given the weak justification to add more hooks to critical
fast-path.

  [0] https://lore.kernel.org/netdev/cover.1583927267.git.lukas@wunner.de/
  [1] https://lore.kernel.org/netdev/20200318.011152.72770718915606186.davem@davemloft.net/

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Cc: David Miller <davem@davemloft.net>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Alexei Starovoitov <ast@kernel.org>
Nacked-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/netdevice.h
include/linux/netfilter_ingress.h [new file with mode: 0644]
include/linux/netfilter_netdev.h [deleted file]
include/uapi/linux/netfilter.h
net/core/dev.c
net/netfilter/Kconfig
net/netfilter/core.c
net/netfilter/nft_chain_filter.c