staging: vme_user: Fix possible UAF in tsi148_dma_list_add
authorGaosheng Cui <cuigaosheng1@huawei.com>
Thu, 17 Nov 2022 03:59:14 +0000 (11:59 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 22 Nov 2022 12:20:13 +0000 (13:20 +0100)
commit357057ee55d3c99a5de5abe8150f7bca04f8e53b
tree42fa68c6a7c3b71dd8d051aed217d4b4eb8ae152
parentccdbe14b77a5e39496baf632e157f9daf322dd27
staging: vme_user: Fix possible UAF in tsi148_dma_list_add

Smatch report warning as follows:

drivers/staging/vme_user/vme_tsi148.c:1757 tsi148_dma_list_add() warn:
  '&entry->list' not removed from list

In tsi148_dma_list_add(), the error path "goto err_dma" will not
remove entry->list from list->entries, but entry will be freed,
then list traversal may cause UAF.

Fix by removeing it from list->entries before free().

Fixes: b2383c90a9d6 ("vme: tsi148: fix first DMA item mapping")
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
Link: https://lore.kernel.org/r/20221117035914.2954454-1-cuigaosheng1@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vme_user/vme_tsi148.c