drm/amd: Make sure image is written to trigger VBIOS image update flow
authorMario Limonciello <mario.limonciello@amd.com>
Wed, 7 Jun 2023 06:41:22 +0000 (01:41 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 9 Jun 2023 16:47:50 +0000 (12:47 -0400)
commit3537d6a48c50ed37e419f89931a5acdb6c56c6d6
tree398191954055a15a8da882023891d0893865125d
parent55682a893844cc64e3a85806b0c3ca7a77b905c3
drm/amd: Make sure image is written to trigger VBIOS image update flow

The VBIOS image update flow requires userspace to:
1) Write the image to `psp_vbflash`
2) Read `psp_vbflash`
3) Poll `psp_vbflash_status` to check for completion

If userspace reads `psp_vbflash` before writing an image, it's
possible that it causes problems that can put the dGPU into an invalid
state.

Explicitly check that an image has been written before letting a read
succeed.

Cc: stable@vger.kernel.org
Fixes: 8424f2ccb3c0 ("drm/amdgpu/psp: Add vbflash sysfs interface support")
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c