[CMake] Make omitting CMAKE_BUILD_TYPE an error
authorTobias Hieta <tobias@hieta.se>
Fri, 29 Apr 2022 09:42:06 +0000 (11:42 +0200)
committerTobias Hieta <tobias@hieta.se>
Wed, 4 May 2022 12:01:33 +0000 (14:01 +0200)
commit350bdf9227cebceb7b7a283f90f504555bf6c496
tree7764b215303e84af0da8b8d8b36ef6e181d5f577
parentcbd3902fa397dce7b3958b48470ef0c04ac4d45b
[CMake] Make omitting CMAKE_BUILD_TYPE an error

After a lot of discussion in this diff the consensus was that it is really hard to guess the users intention with their LLVM build. Instead of trying to guess if Debug or Release is the correct default option we opted for just not specifying CMAKE_BUILD_TYPE a error.

Discussion on discourse here:
https://discourse.llvm.org/t/rfc-select-a-better-linker-by-default-or-warn-about-using-bfd

Reviewed By: hans, mehdi_amini, aaron.ballman, jhenderson, MaskRay, awarzynski

Differential Revision: https://reviews.llvm.org/D124153
llvm/CMakeLists.txt
llvm/docs/AdvancedBuilds.rst
llvm/docs/GettingStarted.rst
llvm/docs/HowToCrossCompileLLVM.rst
llvm/docs/ReleaseNotes.rst
llvm/docs/TestSuiteGuide.md