brcmsmac: Drop unnecessary NULL check after container_of
authorGuenter Roeck <linux@roeck-us.net>
Tue, 11 May 2021 23:56:29 +0000 (16:56 -0700)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 15 Jun 2021 10:42:30 +0000 (13:42 +0300)
commit34fe7038a3b33b4b50b1e948e005bf3db20b7a54
tree896cfe678a9cb1c5b6673e35d1cc70be78c74c32
parentc0277e25d28fc534c09e140c19d5b85f9e7f86fd
brcmsmac: Drop unnecessary NULL check after container_of

The parameter passed to ai_detach() is guaranteed to never be NULL
because it is checked by the caller. Consequently, the result of
container_of() on it is also never NULL, and a NULL check on it
is unnecessary. Even without that, the NULL check would still be
unnecessary because the subsequent kfree() can handle NULL arguments.
On top of all that, it is misleading to check the result of container_of()
against NULL because the position of the contained element could change,
which would make the check invalid. Remove it.

This change was made automatically with the following Coccinelle script.

@@
type t;
identifier v;
statement s;
@@

<+...
(
  t v = container_of(...);
|
  v = container_of(...);
)
  ...
  when != v
- if (\( !v \| v == NULL \) ) s
...+>

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210511235629.1686038-1-linux@roeck-us.net
drivers/net/wireless/broadcom/brcm80211/brcmsmac/aiutils.c