f2fs: Avoid double lock for cp_rwsem during checkpoint
authorSayali Lokhande <sayalil@codeaurora.org>
Thu, 30 Apr 2020 10:58:29 +0000 (16:28 +0530)
committerJaegeuk Kim <jaegeuk@kernel.org>
Tue, 12 May 2020 03:36:47 +0000 (20:36 -0700)
commit34c061ad85a2f5d5e9e3b045d72f3b211db6e282
tree82291cc1ba147c8eaa395da771ccd4ea65807519
parentbaaa7ebf25c78c5cb712fac16b7f549100beddd3
f2fs: Avoid double lock for cp_rwsem during checkpoint

There could be a scenario where f2fs_sync_node_pages gets
called during checkpoint, which in turn tries to flush
inline data and calls iput(). This results in deadlock as
iput() tries to hold cp_rwsem, which is already held at the
beginning by checkpoint->block_operations().

Call stack :

Thread A Thread B
f2fs_write_checkpoint()
- block_operations(sbi)
 - f2fs_lock_all(sbi);
  - down_write(&sbi->cp_rwsem);

                        - open()
                         - igrab()
                        - write() write inline data
                        - unlink()
- f2fs_sync_node_pages()
 - if (is_inline_node(page))
  - flush_inline_data()
   - ilookup()
     page = f2fs_pagecache_get_page()
     if (!page)
      goto iput_out;
     iput_out:
-close()
-iput()
       iput(inode);
       - f2fs_evict_inode()
        - f2fs_truncate_blocks()
         - f2fs_lock_op()
           - down_read(&sbi->cp_rwsem);

Fixes: 2049d4fcb057 ("f2fs: avoid multiple node page writes due to inline_data")
Signed-off-by: Sayali Lokhande <sayalil@codeaurora.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/checkpoint.c
fs/f2fs/f2fs.h
fs/f2fs/node.c