misc/pch_phub.c: use generic power management
authorVaibhav Gupta <vaibhavgupta40@gmail.com>
Mon, 29 Jun 2020 08:15:31 +0000 (13:45 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 29 Jun 2020 16:43:42 +0000 (18:43 +0200)
commit34afa1d657d4742c9bce4a4c197ebf61b4af1b9e
treee83dc84729f0c08fd437b558ee303d48c2c567a4
parent6bbf52566bf7cb26546ec9d9aa76a3cb80d4eb18
misc/pch_phub.c: use generic power management

Drivers should not use legacy power management as they have to manage power
states and related operations, for the device, themselves. This driver was
handling them with the help of PCI helper functions like
pci_save/restore_state(), pci_enable/disable_device(), etc.

With generic PM, all essentials will be handled by the PCI core. Driver
needs to do only device-specific operations.

The driver was also using pci_enable_wake(...,..., 0) to disable wake. Use
device_wakeup_disable() instead. It was also saving device register
configuration using pch_phub_save/restore_reg_conf() which is not
recommended.

Compile-tested only.

Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Link: https://lore.kernel.org/r/20200629081531.214734-6-vaibhavgupta40@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/pch_phub.c