[netdrvr] smc911x: fix for driver resume (and compilation warning)
authorDasgupta, Romit <romit@ti.com>
Thu, 6 Nov 2008 10:16:18 +0000 (15:46 +0530)
committerJeff Garzik <jgarzik@redhat.com>
Tue, 11 Nov 2008 08:53:15 +0000 (03:53 -0500)
commit347c8d83cd9f546a8357e1ab12fa6867707975d8
tree249477b77857f558aebccc5e4b48932804303121
parentcf3760dad576c8dfb4fef4b8a8a08a027bf02583
[netdrvr] smc911x: fix for driver resume (and compilation warning)

I am trying out suspend, resume on an OMAP3 based board. What I see
during resume is that the SMC911x driver resume routing gets stuck
after trying to transmit the packet out of the controller. Some debug
messages below:

--> smc911x_drv_resume
eth0: --> smc911x_reset
eth0: smc911x_reset timeout waiting for PM restore
eth0: --> smc911x_enable
eth0: --> smc911x_phy_configure()
eth0: --> smc911x_phy_reset()
eth0: phy caps=0x782d
eth0: phy advertised caps=0x0de1
eth0: --> smc911x_phy_check_media
smc911x_phy_read: phyaddr=0x1, phyreg=0x01, phydata=0x7809
smc911x_phy_read: phyaddr=0x1, phyreg=0x01, phydata=0x7809
eth0: link down
Restarting tasks ... eth0: --> smc911x_hard_start_xmit
eth0: --> smc911x_hardware_send_pkt
eth0: --> smc911x_hard_start_xmit
eth0: --> smc911x_hardware_send_pkt
eth0: --> smc911x_hard_start_xmit
eth0: --> smc911x_hardware_send_pkt
nfs: server 172.24.190.217 not responding, still trying
nfs: server 172.24.190.217 not responding, still trying

The following change makes it work fine: (The change within
smc911x_drv_probe function was to get rid of a compilation warning).

Signed-off-by: Romit Dasgupta <romit@ti.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/net/smc911x.c