Add docker/lint.sh, for running dockerized lint scripts locally (#6333)
authorAndrew Reusch <areusch@octoml.ai>
Fri, 28 Aug 2020 16:27:09 +0000 (09:27 -0700)
committerGitHub <noreply@github.com>
Fri, 28 Aug 2020 16:27:09 +0000 (09:27 -0700)
commit34647ed8defcc52e4d5a173feb577caf35df7a82
tree55457de248e61f41f85f4f59b715c8ba52d92c70
parent02b643be282adc57f00ddd30fba7d35a2be91dbd
Add docker/lint.sh, for running dockerized lint scripts locally (#6333)

* Add -i option to docker/bash.sh

 * Allows scripts to invoke dockerized commands interactively, for
   better Ctrl+C.

* Add docker/lint.sh to run lint step locally in the docker VM.

 * This allows developers to run lint using the official versions of
   the lint tools without needing to lookup the docker image name.
 * Move all lint scripts to tests/lint/
 * Point Makefile to those new scripts.
 * Update apache rat script to filter untracked/gitignore'd files when
   run with `docker/lint.sh`.

* fix bash_source[0]

* explicitly set the author for CI

* try environment variable override

* try config option

* remove =traditional from ignored option to increase git compat

* address comments, fix behavior under git worktrees

* address cppdocs comments

* address lint.sh comments

* address zhi comments, update pull_request rst
15 files changed:
Jenkinsfile
Makefile
docker/bash.sh
docker/dev_common.sh [new file with mode: 0644]
docker/lint.sh [new file with mode: 0755]
docs/contribute/pull_request.rst
tests/lint/check_asf_header.sh [new file with mode: 0755]
tests/lint/clang_format.sh [new file with mode: 0755]
tests/lint/cppdocs.sh [new file with mode: 0755]
tests/lint/cpplint.sh [new file with mode: 0755]
tests/lint/filter_untracked.py [new file with mode: 0644]
tests/lint/jnilint.sh [new file with mode: 0755]
tests/lint/pylint.sh [new file with mode: 0755]
tests/python/unittest/test_filter_untracked.py [new file with mode: 0644]
tests/scripts/task_lint.sh