drm/i915: Avoid live-lock with i915_vma_parked()
authorChris Wilson <chris@chris-wilson.co.uk>
Mon, 23 Mar 2020 09:28:35 +0000 (09:28 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Mon, 23 Mar 2020 11:16:14 +0000 (11:16 +0000)
commit3447c4c55d0edc95742fdcd91c3efb050546b907
treeba2a45ab881ea230b57af055a9e6895a0d7a0271
parent8e87e0139aff59c5961347ab1ef06814f092c439
drm/i915: Avoid live-lock with i915_vma_parked()

Abuse^W Take advantage that we know we are inside the GT wakeref and
that prevents any client execbuf from reopening the i915_vma in order to
claim all the vma to close without having to drop the spinlock to free
each one individually. By keeping the spinlock, we do not have to
restart if we run concurrently with i915_gem_free_objects -- which
causes them both to restart continually and make very very slow
progress.

Closes: https://gitlab.freedesktop.org/drm/intel/issues/1361
Fixes: 77853186e547 ("drm/i915: Claim vma while under closed_lock in i915_vma_parked()")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200323092841.22240-2-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/i915_vma.c