snapshot: add bdrv_drain_all() to bdrv_snapshot_delete() to avoid concurrency problem
authorZhang Haoyu <zhanghy@sangfor.com>
Tue, 21 Oct 2014 08:38:01 +0000 (16:38 +0800)
committerStefan Hajnoczi <stefanha@redhat.com>
Mon, 3 Nov 2014 09:48:42 +0000 (09:48 +0000)
commit3432a1929ee18e08787ce35476abd74f2c93a17c
tree13a81c0a46707d91622f1593ccf7b926935371fd
parent573742a5431a99ceaba6968ae269cee247727cce
snapshot: add bdrv_drain_all() to bdrv_snapshot_delete() to avoid concurrency problem

If there are still pending i/o while deleting snapshot,
because deleting snapshot is done in non-coroutine context, and
the pending i/o read/write (bdrv_co_do_rw) is done in coroutine context,
so it's possible to cause concurrency problem between above two operations.
Add bdrv_drain_all() to bdrv_snapshot_delete() to avoid this problem.

Signed-off-by: Zhang Haoyu <zhanghy@sangfor.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 201410211637596311287@sangfor.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
block/snapshot.c