wifi: cfg80211: Annotate struct cfg80211_pmsr_request with __counted_by
authorKees Cook <keescook@chromium.org>
Thu, 17 Aug 2023 21:15:26 +0000 (14:15 -0700)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 22 Aug 2023 11:18:16 +0000 (13:18 +0200)
commit342bc7c9e877847d602c4a67c3135051df07cc4d
tree82df375d8e4e0a7f73fd0904507375d3c57dc9cb
parentc14679d7005a4d26289eadb4f5fe499aca78ef7c
wifi: cfg80211: Annotate struct cfg80211_pmsr_request with __counted_by

Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct cfg80211_pmsr_request.
Additionally, since the element count member must be set before accessing
the annotated flexible array member, move its initialization earlier.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Link: https://lore.kernel.org/r/20230817211531.4193219-4-keescook@chromium.org
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
include/net/cfg80211.h
net/wireless/pmsr.c