ASoC: amd: acp: Fix possible UAF in acp_dma_open
authorGaosheng Cui <cuigaosheng1@huawei.com>
Fri, 18 Nov 2022 03:00:56 +0000 (11:00 +0800)
committerMark Brown <broonie@kernel.org>
Fri, 18 Nov 2022 11:50:29 +0000 (11:50 +0000)
commit3420fdb8ae99f0a08d78d2b80f42a71971cf478d
tree30c1276884efa778629021f02d9a2381d7bb65a7
parent13c459fa37c9f26e9bf884a832dd67598b5c4d3e
ASoC: amd: acp: Fix possible UAF in acp_dma_open

Smatch report warning as follows:

sound/soc/amd/acp/acp-platform.c:199 acp_dma_open() warn:
  '&stream->list' not removed from list

If snd_pcm_hw_constraint_integer() fails in acp_dma_open(),
stream will be freed, but stream->list will not be removed from
adata->stream_list, then list traversal may cause UAF.

Fix by adding the newly allocated stream to the list once it's fully
initialised.

Fixes: 7929985cfe36 ("ASoC: amd: acp: Initialize list to store acp_stream during pcm_open")
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
Link: https://lore.kernel.org/r/20221118030056.3135960-1-cuigaosheng1@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/amd/acp/acp-platform.c