ses: Fix problems with simple enclosures
authorJames Bottomley <James.Bottomley@HansenPartnership.com>
Tue, 8 Dec 2015 17:00:31 +0000 (09:00 -0800)
committerJames Bottomley <James.Bottomley@HansenPartnership.com>
Thu, 10 Dec 2015 16:14:03 +0000 (08:14 -0800)
commit3417c1b5cb1fdc10261dbed42b05cc93166a78fd
tree76eb39bd1254171daf12a0e813a80b96a9ab961c
parent527e9316f8ec44bd53d90fb9f611fa7ffff52bb9
ses: Fix problems with simple enclosures

Simple enclosure implementations (mostly USB) are allowed to return only
page 8 to every diagnostic query.  That really confuses our
implementation because we assume the return is the page we asked for and
end up doing incorrect offsets based on bogus information leading to
accesses outside of allocated ranges.  Fix that by checking the page
code of the return and giving an error if it isn't the one we asked for.
This should fix reported bugs with USB storage by simply refusing to
attach to enclosures that behave like this.  It's also good defensive
practise now that we're starting to see more USB enclosures.

Reported-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Cc: stable@vger.kernel.org
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/scsi/ses.c