block: delay freeing the gendisk
authorChristoph Hellwig <hch@lst.de>
Thu, 22 Jul 2021 07:53:54 +0000 (09:53 +0200)
committerJens Axboe <axboe@kernel.dk>
Wed, 28 Jul 2021 01:35:47 +0000 (19:35 -0600)
commit340e84573878b2b9d63210482af46883366361b9
treec3ac4c16cb0f62c1e3d01a087b51ad69a87257a5
parent5ab189cf3abbc9994bae3be524c5b88589ed56e2
block: delay freeing the gendisk

blkdev_get_no_open acquires a reference to the block_device through
the block device inode and then tries to acquire a device model
reference to the gendisk.  But at this point the disk migh already
be freed (although the race is free).  Fix this by only freeing the
gendisk from the whole device bdevs ->free_inode callback as well.

Fixes: 22ae8ce8b892 ("block: simplify bdev/disk lookup in blkdev_get")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20210722075402.983367-2-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/genhd.c
fs/block_dev.c