cifs: prevent use-after-free by freeing the cfile later
authorShyam Prasad N <sprasad@microsoft.com>
Thu, 22 Jun 2023 18:16:03 +0000 (18:16 +0000)
committerSteve French <stfrench@microsoft.com>
Wed, 28 Jun 2023 16:46:32 +0000 (11:46 -0500)
commit33f736187d08f6bc822117629f263b97d3df4165
tree59ae7a75edb9e1ff59afcf294bf7825003d04d02
parentf0b6a834a8f0d267a112b150827bb65d4fdc471c
cifs: prevent use-after-free by freeing the cfile later

In smb2_compound_op we have a possible use-after-free
which can cause hard to debug problems later on.

This was revealed during stress testing with KASAN enabled
kernel. Fixing it by moving the cfile free call to
a few lines below, after the usage.

Fixes: 76894f3e2f71 ("cifs: improve symlink handling for smb2+")
Reviewed-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/smb2inode.c