[merp] MONO_DEBUG=no-gdb-stacktrace shouldn't disable MERP (#2149)
authormonojenkins <jo.shields+jenkins@xamarin.com>
Wed, 29 Jan 2020 15:03:12 +0000 (10:03 -0500)
committerGitHub <noreply@github.com>
Wed, 29 Jan 2020 15:03:12 +0000 (10:03 -0500)
commit33deebe9ff62a7c2c8e802f501f4ea616b6b0a64
tree4e57077798026b8dce1ecc691b72dbe0b2d85ef8
parentc541ea976b7cdae36462392d774b02bad7ea328e
[merp] MONO_DEBUG=no-gdb-stacktrace shouldn't disable MERP (#2149)

Only prevent `gdb` or `lldb` from being invoked.

MERP is controlled by separate mechanisms --- configure flags for crash
reporting and an explicit opt-in icall.

The existing code collects crashed process data in-process, but it writes the
data out (using mono_merp_invoke) in the forked child process.  This is a bit
surprising, but in the interest of not disturbing the code too much, this PR
doesn't change that.  We should revisit `dump_native_stacktrace` again in the
future and rationalize these decisions.

Addresses https://github.com/mono/mono/issues/18565

Co-authored-by: Aleksey Kliger <alklig@microsoft.com>
src/mono/mono/mini/mini-posix.c