pwm: Fix pwm_apply_args()
authorBoris Brezillon <boris.brezillon@free-electrons.com>
Wed, 22 Jun 2016 07:25:14 +0000 (09:25 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Thu, 23 Jun 2016 16:37:05 +0000 (18:37 +0200)
commit33cdcee04be3b4482be97393167e7561b2584e1e
tree4aa9751b50c199d016d111abbe4bc011f060effa
parentcc51846ba81ca179a3be20f6313e3b72531888c1
pwm: Fix pwm_apply_args()

Commit 5ec803edcb70 ("pwm: Add core infrastructure to allow atomic
updates"), implemented pwm_disable() as a wrapper around
pwm_apply_state(), and then, commit ef2bf4997f7d ("pwm: Improve args
checking in pwm_apply_state()") added missing checks on the ->period
value in pwm_apply_state() to ensure we were not passing inappropriate
values to the ->config() or ->apply() methods.

The conjunction of these 2 commits led to a case where pwm_disable()
was no longer succeeding, thus preventing the polarity setting done
in pwm_apply_args().

Set a valid period in pwm_apply_args() to ensure polarity setting
won't be rejected.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Suggested-by: Brian Norris <briannorris@chromium.org>
Fixes: 5ec803edcb70 ("pwm: Add core infrastructure to allow atomic updates")
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
include/linux/pwm.h