ASoC: Intel: boards: fix xrun issue on platform with max98373
authorRander Wang <rander.wang@intel.com>
Fri, 25 Jun 2021 20:50:39 +0000 (15:50 -0500)
committerMark Brown <broonie@kernel.org>
Mon, 28 Jun 2021 15:27:47 +0000 (16:27 +0100)
commit33c8516841ea4fa12fdb8961711bf95095c607ee
treea84d774fa67d661f4242f9dbca5272966a9404e8
parent6a7f5bd6185e1c86256d5e52c3bb7a4d390d6e19
ASoC: Intel: boards: fix xrun issue on platform with max98373

On TGL platform with max98373 codec the trigger start sequence is
fe first, then codec component and sdw link is the last. Recently
a delay was introduced in max98373 codec driver and this resulted
to the start of sdw stream transmission was delayed and the data
transmitted by fw can't be consumed by sdw controller, so xrun happened.

Adding delay in trigger function is a bad idea. This patch enable spk
pin in prepare function and disable it in hw_free to avoid xrun issue
caused by delay in trigger.

Fixes: 3a27875e91fb ("ASoC: max98373: Added 30ms turn on/off time delay")
BugLink: https://github.com/thesofproject/sof/issues/4066
Reviewed-by: Bard Liao <bard.liao@intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Signed-off-by: Rander Wang <rander.wang@intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210625205042.65181-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/boards/sof_sdw_max98373.c