Input: document and check on implicitly defined FF_MAX_EFFECTS
authorElias Vanderstuyft <elias.vds@gmail.com>
Thu, 15 Oct 2015 00:29:37 +0000 (17:29 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 16 Oct 2015 22:32:16 +0000 (15:32 -0700)
commit33b96d934902f96e901b72ac18bbc47afad1ac20
tree5dcd2df3497f413de865e0f219905021effd49d7
parent52a9266788324edbbfd45f02cf23440c01ee0432
Input: document and check on implicitly defined FF_MAX_EFFECTS

There is an undocumented upper bound for the total number of ff effects:
    FF_GAIN (= 96).
This can be found as follows:
- user: write(EV_FF, effect_id, iterations)
    calls kernel: ff->playback(effect_id, ...): starts effect "effect_id"
- user: write(EV_FF, FF_GAIN, gain)
    calls kernel: ff->set_gain(gain, ...): sets gain

A collision occurs when effect_id equals FF_GAIN.
According to input_ff_event(),
FF_GAIN is the smallest value where a collision occurs.
Therefore the greatest safe value for effect_id is FF_GAIN - 1,
and thus the total number of effects should never exceed FF_GAIN.

Define FF_MAX_EFFECTS as FF_GAIN and check on this limit in ff-core.

Signed-off-by: Elias Vanderstuyft <elias.vds@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/ff-core.c
include/uapi/linux/input.h