bpf: Increase supported cgroup storage value size
authorStanislav Fomichev <sdf@google.com>
Tue, 27 Jul 2021 22:23:35 +0000 (15:23 -0700)
committerAndrii Nakryiko <andrii@kernel.org>
Tue, 27 Jul 2021 22:59:29 +0000 (15:59 -0700)
commit33b57e0cc78eb82f2921eb4c6d1c8fcaa733823b
tree353b54e322ce3e6207a184d048df4e2b14c82f0e
parent043c5bb3c4f43670ab4fea0b847373ab42d25f3e
bpf: Increase supported cgroup storage value size

Current max cgroup storage value size is 4k (PAGE_SIZE). The other local
storages accept up to 64k (BPF_LOCAL_STORAGE_MAX_VALUE_SIZE). Let's align
max cgroup value size with the other storages.

For percpu, the max is 32k (PCPU_MIN_UNIT_SIZE) because percpu
allocator is not happy about larger values.

netcnt test is extended to exercise those maximum values
(non-percpu max size is close to, but not real max).

v4:
* remove inner union (Andrii Nakryiko)
* keep net_cnt on the stack (Andrii Nakryiko)

v3:
* refine SIZEOF_BPF_LOCAL_STORAGE_ELEM comment (Yonghong Song)
* anonymous struct in percpu_net_cnt & net_cnt (Yonghong Song)
* reorder free (Yonghong Song)

v2:
* cap max_value_size instead of BUILD_BUG_ON (Martin KaFai Lau)

Signed-off-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Link: https://lore.kernel.org/bpf/20210727222335.4029096-1-sdf@google.com
kernel/bpf/local_storage.c
tools/testing/selftests/bpf/netcnt_common.h
tools/testing/selftests/bpf/progs/netcnt_prog.c
tools/testing/selftests/bpf/test_netcnt.c