Local live builds not picking up runtime config (#2093)
authorJared Parsons <jaredpparsons@gmail.com>
Fri, 31 Jan 2020 00:35:27 +0000 (16:35 -0800)
committerGitHub <noreply@github.com>
Fri, 31 Jan 2020 00:35:27 +0000 (16:35 -0800)
commit33a6ed57e354f270d86ac4b337c07691298093f2
tree3e4bde47ad6ec3543a6a9b472020f48aefa3db22
parent10717887317beb824e57cdb29417663615211e99
Local live builds not picking up runtime config (#2093)

* Local live builds not picking up runtime config

The local live builds were not properly picking up the runtime
configuration varaible. This meant that libraries always attempted to
build against a Debug CoreCLR even if the developer specified
`-runtimeConfiguration Release`

* PR Feedback:

- Ensure that `$(RuntimeConfiguration)` is always set
- Remove duplicated logic in Subsets.props

* Remove unnecessary properties

* Progress

* Mix configurations

Change the live / live jobs so they mix release and debug
configurations. This will help ensure we avoid future breaks in this
area

* Undo MonoOsGorup delete

* Correct the import order

* Publish binary logs

* Pass -ci as this is a CI build

* Progress

* Test

* Set ArtifactsObjDir early enough for Mono

Mono currently relies on ArtifactsObjDir when setting
BaseIntermediateOutputPath. Not setting it leads to restore issues.

* Don't overwrite the properties

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Directory.Build.props
eng/Build.props
eng/Configurations.props [new file with mode: 0644]
eng/Subsets.props
eng/liveBuilds.targets
eng/pipelines/common/global-build-job.yml
eng/pipelines/global-build.yml
src/coreclr/build.cmd
src/coreclr/build.sh
src/libraries/Directory.Build.targets
src/libraries/shims/manual/Directory.Build.props