QHash security fix (1/2): add global QHash seed
authorGiuseppe D'Angelo <dangelog@gmail.com>
Sat, 24 Mar 2012 08:36:52 +0000 (08:36 +0000)
committerQt by Nokia <qt-info@nokia.com>
Tue, 3 Apr 2012 17:12:13 +0000 (19:12 +0200)
commit33984e72abf6c3aa1fed37740d8731c96f68d6e2
tree5856aae74d79ee32251bfaa5ec45a867f40ac131
parent911eed0f90d84b22db69f43eda33ca4ee4965b52
QHash security fix (1/2): add global QHash seed

Algorithmic complexity attacks against hash tables have been known
since 2003 (cf. [1, 2]), and they have been left unpatched for years
until the 2011 attacks [3] against many libraries /
(reference) implementations of programming languages.

This patch adds a global integer, to be used as a seed for the hash
function itself. The seed is randomly initialized the first time a
QHash detaches from shared_null.

Right now the seed is not used at all -- another patch will modify
qHash to make use of it.

[1] http://www.cs.rice.edu/~scrosby/hash/CrosbyWallach_UsenixSec2003.pdf
[2] http://perldoc.perl.org/perlsec.html#Algorithmic-Complexity-Attacks
[3] http://www.ocert.org/advisories/ocert-2011-003.html

Task-number: QTBUG-23529
Change-Id: I7519e4c02b9c2794d1c14079b01330eb356e9c65
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
qmake/qmake_pch.h
src/corelib/global/qt_pch.h
src/corelib/tools/qhash.cpp
src/corelib/tools/qhash.h
tools/configure/configure_pch.h