libstdc++: Add returns_nonnull to non-inline std::map detail [PR108554]
authorJonathan Wakely <jwakely@redhat.com>
Thu, 26 Jan 2023 10:55:28 +0000 (10:55 +0000)
committerJonathan Wakely <jwakely@redhat.com>
Thu, 26 Jan 2023 13:38:22 +0000 (13:38 +0000)
commit3376467ce090aa0966d59ca3aea35db4f17a4b47
treee1ef41d1f1965baf9e07254bf777027c6b357efd
parent93e2bf51dedd0870b78b770b72e34b15a7a0d14a
libstdc++: Add returns_nonnull to non-inline std::map detail [PR108554]

std::map uses a non-inline function to rebalance its tree and the
compiler can't see that it always returns a valid pointer (assuming
valid inputs, which is a precondition anyway). This can result in
-Wnull-derefernce warnings for valid code, because the compiler thinks
there is a path where the function returns null.

Adding the returns_nonnull attribute tells the compiler that is can't
happen. While we're doing that, we might as well also add a nonnull
attribute to the rebalancing functions too.

libstdc++-v3/ChangeLog:

PR libstdc++/108554
* include/bits/stl_tree.h (_Rb_tree_insert_and_rebalance): Add
nonnull attribute.
(_Rb_tree_rebalance_for_erase): Add nonnull and returns_nonnull
attributes.
* testsuite/23_containers/map/modifiers/108554.cc: New test.
libstdc++-v3/include/bits/stl_tree.h
libstdc++-v3/testsuite/23_containers/map/modifiers/108554.cc [new file with mode: 0644]