v9fs_dir_readdir: fix double-free on p9stat_read error
authorDominique Martinet <dominique.martinet@cea.fr>
Mon, 27 Aug 2018 06:12:05 +0000 (15:12 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 1 Dec 2018 08:42:50 +0000 (09:42 +0100)
commit335f31342699f9015f0ab5a8d41d6c911085f033
tree3f90d657e4f2930599e9c092a449f43d46449505
parent3b99dcd4026a08fc9d1fd5cc0a9fc50529803fca
v9fs_dir_readdir: fix double-free on p9stat_read error

commit 81c99089bce693b94b775b6eb888115d2d540086 upstream.

p9stat_read will call p9stat_free on error, we should only free the
struct content on success.

There also is no need to "p9stat_init" st as the read function will
zero the whole struct for us anyway, so clean up the code a bit while
we are here.

Link: http://lkml.kernel.org/r/1535410108-20650-1-git-send-email-asmadeus@codewreck.org
Signed-off-by: Dominique Martinet <dominique.martinet@cea.fr>
Reported-by: syzbot+d4252148d198410b864f@syzkaller.appspotmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/9p/vfs_dir.c