drm/amdgpu: fix warning for overflow check
authorArnd Bergmann <arnd@arndb.de>
Mon, 27 Sep 2021 12:58:10 +0000 (14:58 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 29 Sep 2021 21:30:00 +0000 (17:30 -0400)
commit335aea75b0d95518951cad7c4c676e6f1c02c150
tree8f2b545bf0b58062027782f1f706ca9ab8260569
parent2f350ddadca3b96c72ed1481875f0b8fc1a01612
drm/amdgpu: fix warning for overflow check

The overflow check in amdgpu_bo_list_create() causes a warning with
clang-14 on 64-bit architectures, since the limit can never be
exceeded.

drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c:74:18: error: result of comparison of constant 256204778801521549 with expression of type 'unsigned int' is always false [-Werror,-Wtautological-constant-out-of-range-compare]
        if (num_entries > (SIZE_MAX - sizeof(struct amdgpu_bo_list))
            ~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The check remains useful for 32-bit architectures, so just avoid the
warning by using size_t as the type for the count.

Fixes: 920990cb080a ("drm/amdgpu: allocate the bo_list array after the list")
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c
drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.h