edje: Add workaround for misuses of clip_set
Author: Jean-Philippe Andre <jp.andre@samsung.com>
AuthorDate: Mon Apr 10 16:01:28 2017 +0900
Commit: Jean-Philippe Andre <jp.andre@samsung.com>
CommitDate: Mon Apr 10 16:14:45 2017 +0900
edje: Add workaround for misuses of clip_set
An unfortunately very common misuse of clip is as follows:
- Layout A is created (edje object / elm_layout)
- Object B is swallowed inside A
- Clipper C is set to clip B
This is a invalid usage, as layout A takes control over the clip
property of B (just like it does for geometry, visibility, color...).
Since
75ec3a7338c9c2406d4 edje_recalc resets the clip at every calc
loop, as it can change between states.
In the past, edje_recalc did not reset the clip so anyone could
(wrongly) swallow an object and then change its clip from C to modify
its color, mask it, blend it, etc... Even though this was not proper
use of the API, this is not very clearly documented, and since it
worked, it has been (ab)used a lot already.
The result now is that a clipper set from C will become visible
as an opaque white rectangle covering the entire UI. Booh.
This patch is a workaround that should have no impact on well
written applications. As a bonus this avoids an extra call to
clip_set() from edje.
@fix
Change-Id: I30f18a34a1812afa54b980222a51c9988374d805