scsi: lpfc: don't dereference dma_buf->iocbq before null check
authorJames Smart <jsmart2021@gmail.com>
Sat, 4 Mar 2017 17:30:23 +0000 (09:30 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 7 Mar 2017 04:04:22 +0000 (23:04 -0500)
commit332ba3b5d6d27a60d445704ed7c88c7e9f958a30
treedb3d0f0c2d954b532bffe798e6623f7aacb4ad88
parent7aabe84b8a1bb7c3f75fb6a23dc96f8999bdcc8f
scsi: lpfc: don't dereference dma_buf->iocbq before null check

From: Colin Ian King <colin.king@canonical.com>

dma_buf->iocbq is being dereferenced immediately before it is
being null checked, so we have a potential null pointer dereference
bug.  Fix this by only dereferencing it only once we have passed
a null check on the pointer.

Detected by CoverityScan, CID#1411652 ("Dereference before null check")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_mem.c