Revert "ceph: fix dentry leak in splice_dentry()"
authorYan, Zheng <zyan@redhat.com>
Thu, 27 Sep 2018 13:16:05 +0000 (21:16 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 21 Nov 2018 08:24:07 +0000 (09:24 +0100)
commit32ffde79e88f5a943d89b04ca3821ac8fb1ce7e5
tree5e7e88cb0f23d9dac6dac37352fe4d37d4355832
parentfc07f543a6d39399ba425c5bc588920fbdf65f39
Revert "ceph: fix dentry leak in splice_dentry()"

commit efe328230dc01aa0b1269aad0b5fae73eea4677a upstream.

This reverts commit 8b8f53af1ed9df88a4c0fbfdf3db58f62060edf3.

splice_dentry() is used by three places. For two places, req->r_dentry
is passed to splice_dentry(). In the case of error, req->r_dentry does
not get updated. So splice_dentry() should not drop reference.

Cc: stable@vger.kernel.org # 4.18+
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ceph/inode.c