crypto: x86/sha1 - fix possible crash with CFI enabled
authorEric Biggers <ebiggers@google.com>
Fri, 18 Nov 2022 19:44:13 +0000 (11:44 -0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 25 Nov 2022 09:39:19 +0000 (17:39 +0800)
commit32f34bf7e44eeaa241fb845d6f52af5104bc30fd
treee320c7f7e4fa2114be3f52e6cfa0747d33a740c7
parent0f8bc4bd48dd148046c19c38568cd9449c79b45f
crypto: x86/sha1 - fix possible crash with CFI enabled

sha1_transform_ssse3(), sha1_transform_avx(), and sha1_ni_transform()
(but not sha1_transform_avx2()) are called via indirect function calls.
Therefore they need to use SYM_TYPED_FUNC_START instead of
SYM_FUNC_START to cause their type hashes to be emitted when the kernel
is built with CONFIG_CFI_CLANG=y.  Otherwise, the code crashes with a
CFI failure (if the compiler didn't happen to optimize out the indirect
calls).

Fixes: ccace936eec7 ("x86: Add types to indirectly called assembly functions")
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Sami Tolvanen <samitolvanen@google.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
arch/x86/crypto/sha1_ni_asm.S
arch/x86/crypto/sha1_ssse3_asm.S