Revert D108432 "[InstrProfiling] Keep profd non-private for non-renamable comdat...
authorFangrui Song <i@maskray.me>
Wed, 25 Aug 2021 02:16:07 +0000 (19:16 -0700)
committerFangrui Song <i@maskray.me>
Wed, 25 Aug 2021 02:16:07 +0000 (19:16 -0700)
commit32e2326cda441528f75404b1c93374722caaf21c
treee0d30c8060c4979a6e6a246bc320dde749de56d4
parent5541a05d6a5a74424dd6d98cfb6d9014a5fb17ca
Revert D108432 "[InstrProfiling] Keep profd non-private for non-renamable comdat functions"

This reverts commit f653beea88d2684cdc8117e662b321ba04666771.

It broke Windows coverage-inline.cpp because link.exe has a limitation
that external symbols in IMAGE_COMDAT_SELECT_ASSOCIATIVE don't work.

It essentially dropped the previous size optimization for coverage
because coverage doesn't rename comdat by default.
Needs more investigation what we should do.
llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp
llvm/test/Instrumentation/InstrProfiling/linkage.ll
llvm/test/Transforms/PGOProfile/comdat.ll