Add fall-through comments.
authorJoseph Myers <joseph@codesourcery.com>
Tue, 12 Feb 2019 10:30:34 +0000 (10:30 +0000)
committerJoseph Myers <joseph@codesourcery.com>
Tue, 12 Feb 2019 10:30:34 +0000 (10:30 +0000)
commit32db86d558193ad4ad5a00926ce3c350c89eb8df
tree477020d5e3e691134fd40d992bbf66eaa7e18347
parenta51bc4fe9da9f2b97877beb6692f7043f6c14a16
Add fall-through comments.

This patch adds fall-through comments in some cases where -Wextra
produces implicit-fallthrough warnings.

The patch is non-exhaustive.  Apart from architecture-specific code
for non-x86_64 architectures, it does not change sunrpc/xdr.c (legacy
code, probably should have such changes, but left to be dealt with
separately), or places that already had comments about the
fall-through but not matching the form expected by
-Wimplicit-fallthrough=3 (the default level with -Wextra; my
inclination is to adjust those comments to match rather than
downgrading to -Wimplicit-fallthrough=1 to allow any comment), or one
place where I thought the implicit fallthrough was not correct and so
should be handled separately as a bug fix.  I think the key thing to
consider in review of this patch is whether the fall-through is indeed
intended and correct in each place where such a comment is added.

Tested for x86_64.

* elf/dl-exception.c (_dl_exception_create_format): Add
fall-through comments.
* elf/ldconfig.c (parse_conf_include): Likewise.
* elf/rtld.c (print_statistics): Likewise.
* locale/programs/charmap.c (parse_charmap): Likewise.
* misc/mntent_r.c (__getmntent_r): Likewise.
* posix/wordexp.c (parse_arith): Likewise.
(parse_backtick): Likewise.
* resolv/ns_ttl.c (ns_parse_ttl): Likewise.
* sysdeps/x86/cpu-features.c (init_cpu_features): Likewise.
* sysdeps/x86_64/dl-machine.h (elf_machine_rela): Likewise.
ChangeLog
elf/dl-exception.c
elf/ldconfig.c
elf/rtld.c
locale/programs/charmap.c
misc/mntent_r.c
posix/wordexp.c
resolv/ns_ttl.c
sysdeps/x86/cpu-features.c
sysdeps/x86_64/dl-machine.h