perf evlist: Drop redundant evsel->overwrite indicator
authorArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 14 Jul 2016 08:34:33 +0000 (08:34 +0000)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 15 Jul 2016 16:38:06 +0000 (13:38 -0300)
commit32a951b4fd6bbe60ef5d65930b1712321e241b27
tree6900abcdecfb044b93de799a1f7fcc01e9893ad4
parentdb49120a32b347fb93aea3319305932657dd118c
perf evlist: Drop redundant evsel->overwrite indicator

evsel->overwrite indicator means an event should be put into
overwritable ring buffer. In current implementation, it equals to
evsel->attr.write_backward. To reduce compliexity, remove
evsel->overwrite, use evsel->attr.write_backward instead.

In addition, in __perf_evsel__open(), if kernel doesn't support
write_backward and user explicitly set it in evsel, don't fallback
like other missing feature, since it is meaningless to fall back to
a forward ring buffer in this case: we are unable to stably read
from an forward overwritable ring buffer.

Cc: He Kuang <hekuang@huawei.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Nilay Vaish <nilayvaish@gmail.com>
Cc: Wang Nan <wangnan0@huawei.com>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1468485287-33422-2-git-send-email-wangnan0@huawei.com
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/tests/backward-ring-buffer.c
tools/perf/util/evlist.c
tools/perf/util/evsel.c
tools/perf/util/evsel.h