igc: fix link speed advertising
authorCorinna Vinschen <vinschen@redhat.com>
Tue, 17 Nov 2020 19:50:40 +0000 (20:50 +0100)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Tue, 26 Jan 2021 21:39:26 +0000 (13:39 -0800)
commit329a3678ec69962aa67c91397efbd46d36635f91
tree42f9ba05f470e6fbc5a5345144c97f1021328c41
parent67a3c6b3cc40bb217c3ff947a55053151a00fea0
igc: fix link speed advertising

Link speed advertising in igc has two problems:

- When setting the advertisement via ethtool, the link speed is converted
  to the legacy 32 bit representation for the intel PHY code.
  This inadvertently drops ETHTOOL_LINK_MODE_2500baseT_Full_BIT (being
  beyond bit 31).  As a result, any call to `ethtool -s ...' drops the
  2500Mbit/s link speed from the PHY settings.  Only reloading the driver
  alleviates that problem.

  Fix this by converting the ETHTOOL_LINK_MODE_2500baseT_Full_BIT to the
  Intel PHY ADVERTISE_2500_FULL bit explicitly.

- Rather than checking the actual PHY setting, the .get_link_ksettings
  function always fills link_modes.advertising with all link speeds
  the device is capable of.

  Fix this by checking the PHY autoneg_advertised settings and report
  only the actually advertised speeds up to ethtool.

Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
Signed-off-by: Corinna Vinschen <vinschen@redhat.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/igc/igc_ethtool.c