Fix text color in some cases of QML and QStaticText
authorEskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@nokia.com>
Tue, 28 Jun 2011 15:07:13 +0000 (17:07 +0200)
committerQt by Nokia <qt-info@nokia.com>
Thu, 30 Jun 2011 10:48:16 +0000 (12:48 +0200)
commit3296449d5cd9491b56914a23a78d2f78982a6856
tree30607e71d8a91a4ca6481586f49a9e3a5c8501a1
parentdb5aad6a99996b134cb406dc562017690f6a6812
Fix text color in some cases of QML and QStaticText

This reverts 518c2a58ed6fdfd7449cb4476aa8ea0d32ad16e3 which caused a
regression.

When writing systems are mixed and an underline is set on the font,
QPainter will set a pen with the current color and a new width on
itself before drawing the decoration. This would cause the recorder
in QStaticText to mark the pen as dirty, saving the current pen
color in all subsequent text items. The effect was e.g. that in QML
the cached color would override the current one, making it impossible
to change the color on the text without forcing a relayout somehow.

The right fix is to only mark the pen as dirty when its color actually
changes.

Task-number: QTBUG-20159
Change-Id: I0db1966787f543695bcba4a0c13328ae0a17625b
Reviewed-by: Jiang Jiang
Reviewed-on: http://codereview.qt.nokia.com/875
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@nokia.com>
src/declarative/graphicsitems/qdeclarativetextlayout.cpp
src/declarative/graphicsitems/qdeclarativetextlayout_p.h