llvm/ObjCARC: Eliminate inlined AutoreleaseRV calls
authorDuncan P. N. Exon Smith <dexonsmith@apple.com>
Mon, 18 Nov 2019 01:58:01 +0000 (17:58 -0800)
committerDuncan P. N. Exon Smith <dexonsmith@apple.com>
Tue, 19 Nov 2019 20:02:01 +0000 (12:02 -0800)
commit3279724905c14a8db383ade53af40a0dd49504d8
tree0f065a07c499a4622f61337e38a2d3a0d673ae08
parent0a8e7ca402eb3470eb5faf4982581771cb849130
llvm/ObjCARC: Eliminate inlined AutoreleaseRV calls

Pair up inlined AutoreleaseRV calls with their matching RetainRV or
ClaimRV.

- RetainRV cancels out AutoreleaseRV.  Delete both instructions.
- ClaimRV is a peephole for RetainRV+Release.  Delete AutoreleaseRV and
  replace ClaimRV with Release.

This avoids problems where more aggressive inlining triggers memory
regressions.

This patch is happy to skip over non-callable instructions and non-ARC
intrinsics looking for the pair.  It is likely sound to also skip over
opaque function calls, but that's harder to reason about, and it's not
relevant to the goal here: if there's an opaque function call splitting
up a pair, it's very unlikely that a handshake would have happened
dynamically without inlining.

Note that this patch also subsumes the previous logic that looked
backwards from ReleaseRV.

https://reviews.llvm.org/D70370
rdar://problem/46509586
llvm/lib/Transforms/ObjCARC/ObjCARCOpts.cpp
llvm/test/Transforms/ObjCARC/inlined-autorelease-return-value.ll [new file with mode: 0644]
llvm/test/Transforms/ObjCARC/unsafe-claim-rv.ll