cifs: do all necessary checks for credits within or before locking
authorShyam Prasad N <sprasad@microsoft.com>
Thu, 22 Jun 2023 18:16:04 +0000 (18:16 +0000)
committerSteve French <stfrench@microsoft.com>
Wed, 28 Jun 2023 16:46:58 +0000 (11:46 -0500)
commit326a8d04f147e2bf393f6f9cdb74126ee6900607
treecb06c1adce93f03efa282fc0084f0f731bc048d7
parent33f736187d08f6bc822117629f263b97d3df4165
cifs: do all necessary checks for credits within or before locking

All the server credits and in-flight info is protected by req_lock.
Once the req_lock is held, and we've determined that we have enough
credits to continue, this lock cannot be dropped till we've made the
changes to credits and in-flight count.

However, we used to drop the lock in order to avoid deadlock with
the recent srv_lock. This could cause the checks already made to be
invalidated.

Fixed it by moving the server status check to before locking req_lock.

Fixes: d7d7a66aacd6 ("cifs: avoid use of global locks for high contention data")
Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/smb2ops.c
fs/smb/client/transport.c