intel-iommu: Fix leaks in pagetable freeing
authorAlex Williamson <alex.williamson@redhat.com>
Sat, 15 Jun 2013 16:27:19 +0000 (10:27 -0600)
committerJoerg Roedel <joro@8bytes.org>
Wed, 14 Aug 2013 20:21:04 +0000 (22:21 +0200)
commit3269ee0bd6686baf86630300d528500ac5b516d7
treede651f5e9631b3258ff01b3fc97d91b260d29a17
parentd4e4ab86bcba5a72779c43dc1459f71fea3d89c8
intel-iommu: Fix leaks in pagetable freeing

At best the current code only seems to free the leaf pagetables and
the root.  If you're unlucky enough to have a large gap (like any
QEMU guest with more than 3G of memory), only the first chunk of leaf
pagetables are freed (plus the root).  This is a massive memory leak.
This patch re-writes the pagetable freeing function to use a
recursive algorithm and manages to not only free all the pagetables,
but does it without any apparent performance loss versus the current
broken version.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Cc: stable@vger.kernel.org
Reviewed-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Joerg Roedel <joro@8bytes.org>
drivers/iommu/intel-iommu.c