[APSInt][OpenMP] Fix isNegative, etc. for unsigned types
authorJoel E. Denny <jdenny.ornl@gmail.com>
Tue, 23 Apr 2019 17:04:15 +0000 (17:04 +0000)
committerJoel E. Denny <jdenny.ornl@gmail.com>
Tue, 23 Apr 2019 17:04:15 +0000 (17:04 +0000)
commit3234887fe2ea94d5997b4ba9999401459a29905b
tree843fa6636935b50c1cf5a6871a8b19fefc91332e
parentbdb864a5762e10a485c0b76c5677f5c14b4045d7
[APSInt][OpenMP] Fix isNegative, etc. for unsigned types

Without this patch, APSInt inherits APInt::isNegative, which merely
checks the sign bit without regard to whether the type is actually
signed.  isNonNegative and isStrictlyPositive call isNegative and so
are also affected.

This patch adjusts APSInt to override isNegative, isNonNegative, and
isStrictlyPositive with implementations that consider whether the type
is signed.

A large set of Clang OpenMP tests are affected.  Without this patch,
these tests assume that `true` is not a valid argument for clauses
like `collapse`.  Indeed, `true` fails APInt::isStrictlyPositive but
not APSInt::isStrictlyPositive.  This patch adjusts those tests to
assume `true` should be accepted.

This patch also adds tests revealing various other similar fixes due
to APSInt::isNegative calls in Clang's ExprConstant.cpp and
SemaExpr.cpp: `++` and `--` overflow in `constexpr`, evaluated object
size based on `alloc_size`, `<<` and `>>` shift count validation, and
OpenMP array section validation.

Reviewed By: lebedev.ri, ABataev, hfinkel

Differential Revision: https://reviews.llvm.org/D59712

llvm-svn: 359012
64 files changed:
clang/test/CodeGen/alloc-size.c
clang/test/OpenMP/distribute_collapse_messages.cpp
clang/test/OpenMP/distribute_parallel_for_collapse_messages.cpp
clang/test/OpenMP/distribute_parallel_for_simd_collapse_messages.cpp
clang/test/OpenMP/distribute_parallel_for_simd_safelen_messages.cpp
clang/test/OpenMP/distribute_parallel_for_simd_simdlen_messages.cpp
clang/test/OpenMP/distribute_simd_collapse_messages.cpp
clang/test/OpenMP/distribute_simd_safelen_messages.cpp
clang/test/OpenMP/distribute_simd_simdlen_messages.cpp
clang/test/OpenMP/for_collapse_messages.cpp
clang/test/OpenMP/for_ordered_clause.cpp
clang/test/OpenMP/for_simd_collapse_messages.cpp
clang/test/OpenMP/for_simd_safelen_messages.cpp
clang/test/OpenMP/for_simd_simdlen_messages.cpp
clang/test/OpenMP/parallel_for_collapse_messages.cpp
clang/test/OpenMP/parallel_for_ordered_messages.cpp
clang/test/OpenMP/parallel_for_simd_collapse_messages.cpp
clang/test/OpenMP/parallel_for_simd_safelen_messages.cpp
clang/test/OpenMP/parallel_for_simd_simdlen_messages.cpp
clang/test/OpenMP/simd_collapse_messages.cpp
clang/test/OpenMP/simd_safelen_messages.cpp
clang/test/OpenMP/simd_simdlen_messages.cpp
clang/test/OpenMP/target_map_messages.cpp
clang/test/OpenMP/target_parallel_for_collapse_messages.cpp
clang/test/OpenMP/target_parallel_for_map_messages.cpp
clang/test/OpenMP/target_parallel_for_ordered_messages.cpp
clang/test/OpenMP/target_parallel_for_simd_collapse_messages.cpp
clang/test/OpenMP/target_parallel_for_simd_map_messages.cpp
clang/test/OpenMP/target_parallel_for_simd_ordered_messages.cpp
clang/test/OpenMP/target_parallel_for_simd_safelen_messages.cpp
clang/test/OpenMP/target_parallel_for_simd_simdlen_messages.cpp
clang/test/OpenMP/target_parallel_map_messages.cpp
clang/test/OpenMP/target_simd_collapse_messages.cpp
clang/test/OpenMP/target_simd_safelen_messages.cpp
clang/test/OpenMP/target_simd_simdlen_messages.cpp
clang/test/OpenMP/target_teams_distribute_collapse_messages.cpp
clang/test/OpenMP/target_teams_distribute_map_messages.cpp
clang/test/OpenMP/target_teams_distribute_parallel_for_collapse_messages.cpp
clang/test/OpenMP/target_teams_distribute_parallel_for_map_messages.cpp
clang/test/OpenMP/target_teams_distribute_parallel_for_simd_collapse_messages.cpp
clang/test/OpenMP/target_teams_distribute_parallel_for_simd_map_messages.cpp
clang/test/OpenMP/target_teams_distribute_parallel_for_simd_safelen_messages.cpp
clang/test/OpenMP/target_teams_distribute_parallel_for_simd_simdlen_messages.cpp
clang/test/OpenMP/target_teams_distribute_simd_collapse_messages.cpp
clang/test/OpenMP/target_teams_distribute_simd_map_messages.cpp
clang/test/OpenMP/target_teams_distribute_simd_safelen_messages.cpp
clang/test/OpenMP/target_teams_distribute_simd_simdlen_messages.cpp
clang/test/OpenMP/target_teams_map_messages.cpp
clang/test/OpenMP/taskloop_collapse_messages.cpp
clang/test/OpenMP/taskloop_simd_collapse_messages.cpp
clang/test/OpenMP/taskloop_simd_safelen_messages.cpp
clang/test/OpenMP/taskloop_simd_simdlen_messages.cpp
clang/test/OpenMP/teams_distribute_collapse_messages.cpp
clang/test/OpenMP/teams_distribute_parallel_for_collapse_messages.cpp
clang/test/OpenMP/teams_distribute_parallel_for_simd_collapse_messages.cpp
clang/test/OpenMP/teams_distribute_parallel_for_simd_safelen_messages.cpp
clang/test/OpenMP/teams_distribute_parallel_for_simd_simdlen_messages.cpp
clang/test/OpenMP/teams_distribute_simd_collapse_messages.cpp
clang/test/OpenMP/teams_distribute_simd_safelen_messages.cpp
clang/test/OpenMP/teams_distribute_simd_simdlen_messages.cpp
clang/test/Sema/shift.c
clang/test/SemaCXX/constexpr-unsigned-high-bit.cpp [new file with mode: 0644]
llvm/include/llvm/ADT/APSInt.h
llvm/unittests/ADT/APSIntTest.cpp