Rewrite all Property related functions in terms of StringRef.
authorZachary Turner <zturner@google.com>
Thu, 17 Nov 2016 18:08:12 +0000 (18:08 +0000)
committerZachary Turner <zturner@google.com>
Thu, 17 Nov 2016 18:08:12 +0000 (18:08 +0000)
commit31d97a5c8ab78c619deada0cdb1fcf64021d25dd
treea1f642a22b8975a80013c7ab8bc98a7ea763346e
parentff0382c16190cd2b1bc47b27c5db0570b90f1d39
Rewrite all Property related functions in terms of StringRef.

This was a bit tricky, especially for things like
OptionValueArray and OptionValueDictionary since they do some
funky string parsing.  Rather than try to re-write line-by-line
I tried to make the StringRef usage idiomatic, even though
it meant often re-writing from scratch large blocks of code
in a different way while keeping true to the original intent.

The finished code is a big improvement though, and often much
shorter than the original code.  All tests and unit tests
pass on Windows and Linux.

llvm-svn: 287242
24 files changed:
lldb/include/lldb/Core/DataBufferHeap.h
lldb/include/lldb/Core/Debugger.h
lldb/include/lldb/Core/Disassembler.h
lldb/include/lldb/Core/UserSettingsController.h
lldb/include/lldb/Interpreter/OptionValue.h
lldb/include/lldb/Interpreter/OptionValueArray.h
lldb/include/lldb/Interpreter/OptionValueDictionary.h
lldb/include/lldb/Interpreter/OptionValueProperties.h
lldb/include/lldb/Target/ProcessInfo.h
lldb/include/lldb/Target/Target.h
lldb/source/Commands/CommandObjectMemory.cpp
lldb/source/Commands/CommandObjectProcess.cpp
lldb/source/Commands/CommandObjectSettings.cpp
lldb/source/Core/Debugger.cpp
lldb/source/Core/Disassembler.cpp
lldb/source/Core/UserSettingsController.cpp
lldb/source/Interpreter/OptionValue.cpp
lldb/source/Interpreter/OptionValueArgs.cpp
lldb/source/Interpreter/OptionValueArray.cpp
lldb/source/Interpreter/OptionValueDictionary.cpp
lldb/source/Interpreter/OptionValueProperties.cpp
lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp
lldb/source/Target/ProcessInfo.cpp
lldb/source/Target/Target.cpp