netfilter: nftables_offload: KASAN slab-out-of-bounds Read in nft_flow_rule_create
authorSaeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>
Tue, 20 Oct 2020 11:41:36 +0000 (13:41 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Tue, 20 Oct 2020 11:54:54 +0000 (13:54 +0200)
commit31cc578ae2de19c748af06d859019dced68e325d
treec1646d7aa21a762d0745e40426294260e7579ae5
parent64747d5ed19911a867af733f6679d2a859fb18ae
netfilter: nftables_offload: KASAN slab-out-of-bounds Read in nft_flow_rule_create

This patch fixes the issue due to:

BUG: KASAN: slab-out-of-bounds in nft_flow_rule_create+0x622/0x6a2
net/netfilter/nf_tables_offload.c:40
Read of size 8 at addr ffff888103910b58 by task syz-executor227/16244

The error happens when expr->ops is accessed early on before performing the boundary check and after nft_expr_next() moves the expr to go out-of-bounds.

This patch checks the boundary condition before expr->ops that fixes the slab-out-of-bounds Read issue.

Add nft_expr_more() and use it to fix this problem.

Signed-off-by: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
include/net/netfilter/nf_tables.h
net/netfilter/nf_tables_api.c
net/netfilter/nf_tables_offload.c