KEYS: trusted: Fix memory leak on object td
authorColin Ian King <colin.king@canonical.com>
Fri, 30 Apr 2021 11:37:24 +0000 (12:37 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 May 2021 08:12:50 +0000 (10:12 +0200)
commit31c9a4b24d86cbb36ff0d7a085725a3b4f0138c8
treeb3187d13bfe0c214096666c1b593cd24e6ed9a01
parente97bd1e03e6ef58ec47ee7f085f8c14ed6329cf7
KEYS: trusted: Fix memory leak on object td

commit 83a775d5f9bfda95b1c295f95a3a041a40c7f321 upstream.

Two error return paths are neglecting to free allocated object td,
causing a memory leak. Fix this by returning via the error return
path that securely kfree's td.

Fixes clang scan-build warning:
security/keys/trusted-keys/trusted_tpm1.c:496:10: warning: Potential
memory leak [unix.Malloc]

Cc: stable@vger.kernel.org
Fixes: 5df16caada3f ("KEYS: trusted: Fix incorrect handling of tpm_get_random()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
security/keys/trusted-keys/trusted_tpm1.c