ssb: SSB_DRIVER_GPIO should depend on GPIOLIB instead of selecting it
authorGeert Uytterhoeven <geert@linux-m68k.org>
Sun, 16 Dec 2012 15:35:36 +0000 (16:35 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Wed, 2 Jan 2013 19:38:23 +0000 (14:38 -0500)
commit3194f2f04547c3e0da488f0478788fbeebd9a914
tree1dfb990e763888d0627bcf9e2ab6d3342cd22be8
parenta73331141354e800e735d0251307dd10e04ac21a
ssb: SSB_DRIVER_GPIO should depend on GPIOLIB instead of selecting it

Commit ec43b08b5733494ad88aa618ecdf534320dd8207 ("ssb: add GPIO driver")
added SSB_DRIVER_GPIO, which unconditionally selects GPIOLIB, causing
a Kconfig warning:

warning: (ARCH_REQUIRE_GPIOLIB && SSB_DRIVER_GPIO && BCMA_DRIVER_GPIO && MFD_TC6393XB && FB_VIA) selects GPIOLIB which has unmet direct dependencies (ARCH_WANT_OPTIONAL_GPIOLIB || ARCH_REQUIRE_GPIOLIB)

and build failure for m68k/allmodconfig:

In file included from drivers/ssb/ssb_private.h:5,
                 from drivers/ssb/main.c:12:
include/linux/ssb/ssb.h:440: error: field ‘gpio’ has incomplete type
make[4]: *** [drivers/ssb/main.o] Error 1
make[3]: *** [drivers/ssb/] Error 2

Turn the select into a dependency to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/ssb/Kconfig