Revert of Revert of Revert of Add d8 target to the GN build. (patchset #1 id:1 of...
authordcarney <dcarney@chromium.org>
Wed, 14 Jan 2015 11:52:24 +0000 (03:52 -0800)
committerCommit bot <commit-bot@chromium.org>
Wed, 14 Jan 2015 11:52:34 +0000 (11:52 +0000)
commit316f860a6bd5fcb55ce0cd4a950e829d2b16acea
treee904880648c3096ae39abce04514dd2fd17175a3
parentb62f094884b95cf7b45484a27a9721a8477efc91
Revert of Revert of Revert of Add d8 target to the GN build. (patchset #1 id:1 of https://codereview.chromium.org/833563004/)

Reason for revert:
This is now really blocking the roll.  I believe it's just missing

    configs -= [ "//build/config/compiler:chromium_code" ]
    configs += [ "//build/config/compiler:no_chromium_code" ]

in the d8 config but I have no way to check.

Original issue's description:
> Revert of Revert of Add d8 target to the GN build. (patchset #1 id:1 of https://codereview.chromium.org/838983002/)
>
> Reason for revert:
> Relanding because this is not actually blocking the roll.
>
> Original issue's description:
> > Revert of Add d8 target to the GN build. (patchset #2 id:40001 of https://codereview.chromium.org/834113005/)
> >
> > Reason for revert:
> > V8 roll fails due to this change. (see https://codereview.chromium.org/843673003/)
> >
> > Original issue's description:
> > > Add d8 target to the GN build.
> > >
> > > Also formats the rest of the file with "gn format". This accounts for all the changes except for the "d8" target additions.
> > >
> > > Committed: https://crrev.com/36383f08c1f692ea797d54a27d7c6b3d3d53b440
> > > Cr-Commit-Position: refs/heads/master@{#25984}
> >
> > TBR=jochen@chromium.org,machenbach@chromium.org,brettw@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> >
> > Committed: https://crrev.com/ef50fdfdb05e1a3a3822962f5235b804218a5f4e
> > Cr-Commit-Position: refs/heads/master@{#25985}
>
> TBR=jochen@chromium.org,machenbach@chromium.org,brettw@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/ebf3c34fb91b4b61f5c32383a115214c516ab5b0
> Cr-Commit-Position: refs/heads/master@{#25996}

TBR=jochen@chromium.org,machenbach@chromium.org,brettw@chromium.org,yangguo@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/810493004

Cr-Commit-Position: refs/heads/master@{#26050}
BUILD.gn