iommufd: Fix locking around hwpt allocation
authorJason Gunthorpe <jgg@nvidia.com>
Mon, 17 Jul 2023 18:12:07 +0000 (15:12 -0300)
committerJason Gunthorpe <jgg@nvidia.com>
Wed, 26 Jul 2023 13:20:02 +0000 (10:20 -0300)
commit31422dff187b243c58f3a97d16bbe9e9ada639fe
treebbcd275d2b3a104270b676506cd8df0febab80dc
parent70eadc7fc7ef29bfe0e361376983822b5e36dd67
iommufd: Fix locking around hwpt allocation

Due to the auto_domains mechanism the ioas->mutex must be held until
the hwpt is completely setup by iommufd_object_abort_and_destroy() or
iommufd_object_finalize().

This prevents a concurrent iommufd_device_auto_get_domain() from seeing
an incompletely initialized object through the ioas->hwpt_list.

To make this more consistent move the unlock until after finalize.

Fixes: e8d57210035b ("iommufd: Add kAPI toward external drivers for physical devices")
Link: https://lore.kernel.org/r/11-v8-6659224517ea+532-iommufd_alloc_jgg@nvidia.com
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Tested-by: Nicolin Chen <nicolinc@nvidia.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/iommu/iommufd/device.c